Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix rocksdb build type #1340

Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix: fix rocksdb build type #1340

merged 1 commit into from
Feb 7, 2023

Conversation

GehaFearless
Copy link
Contributor

issue: #1339

@acelyc111
Copy link
Member

Good job!
I think this patch should be picked to branch 2.4

@acelyc111 acelyc111 merged commit 4476219 into apache:master Feb 7, 2023
@empiredan empiredan mentioned this pull request Aug 17, 2023
Closed
empiredan pushed a commit to empiredan/pegasus that referenced this pull request Dec 15, 2023
@GehaFearless
fix: fix rocksdb build type (apache#1340)
0873a4c
@empiredan empiredan mentioned this pull request Dec 15, 2023
Merged
empiredan added a commit that referenced this pull request Dec 15, 2023
@empiredan
fix: fix rocksdb build type (cherry-pick #1340) (#1775)
d404314 
#1339

RocksDB library is not built in Release version, which may cause terrible performance issues.

This PR is to cherry-pick #1340 into v2.4 to resolve #1339.
GehaFearless pushed a commit to GehaFearless/incubator-pegasus that referenced this pull request Feb 28, 2024
[SKV-614] fix: fix rocksdb build type (apache#1340)
1a93125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smityz Smityz Smityz approved these changes

@acelyc111 acelyc111 acelyc111 approved these changes

@empiredan empiredan empiredan approved these changes

Assignees
No one assigned
Labels
build thirdparty
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GehaFearless @acelyc111 @empiredan @Smityz