Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(conf): use DSN_DEFINE_int64 to load int64 type of configs #1357

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Feb 19, 2023

#1323

This patch refactors the code to use DSN_DEFINE_int64 instead of dsn_config_get_value_int64/uint64 to load int64 type of configurations, and doesn't introduce any functional changes.

  • all default value and most of description are kept as before
  • move the defination of flags closer to the places where they're used
  • remove checkpoint_min_decree_gap which is never used

NOTE: rocksdb_max_open_files is type of int32 because _db_opts.max_open_files is type of int32.

@acelyc111 acelyc111 merged commit ec905d9 into apache:master Feb 22, 2023
@empiredan empiredan mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants