Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(conf): use DSN_DEFINE_bool to load bool type of configs #1363

Merged
merged 3 commits into from
Feb 27, 2023
Merged

refactor(conf): use DSN_DEFINE_bool to load bool type of configs #1363

merged 3 commits into from
Feb 27, 2023

Conversation

acelyc111
Copy link
Member

#1323

This patch refactors the code to use DSN_DEFINE_bool instead of dsn_config_get_value_bool to load bool type of configurations, and doesn't introduce any functional changes.

  • all default value and most of description are kept as before
  • move the defination of flags closer to the places where they're used

@github-actions github-actions bot added the cpp label Feb 24, 2023
@acelyc111 acelyc111 mentioned this pull request Feb 24, 2023
Closed
empiredan
empiredan reviewed Feb 27, 2023
View reviewed changes
src/replica/storage/simple_kv/simple_kv.server.impl.cpp Outdated Show resolved Hide resolved
src/replica/storage/simple_kv/test/simple_kv.server.impl.cpp Outdated Show resolved Hide resolved
src/utils/simple_logger.cpp Show resolved Hide resolved
src/replica/replica_stub.cpp Outdated Show resolved Hide resolved
@acelyc111 acelyc111 merged commit 9b160a9 into apache:master Feb 27, 2023
@empiredan empiredan mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levy5307 levy5307 levy5307 approved these changes

@empiredan empiredan empiredan approved these changes

@Smityz Smityz Awaiting requested review from Smityz

Assignees
No one assigned
Labels
cpp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acelyc111 @empiredan @levy5307