Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove counter_info and counter_info_ptr #1509

Merged
merged 1 commit into from
Jun 5, 2023
Merged

refactor: remove counter_info and counter_info_ptr #1509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 0 additions & 49 deletions src/runtime/profiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,54 +90,6 @@ std::unique_ptr<task_spec_profiler[]> s_spec_profilers;

int s_task_code_max = 0;

counter_info *counter_info_ptr[] = {
new counter_info({"queue.time", "qt"},
TASK_QUEUEING_TIME_NS,
COUNTER_TYPE_NUMBER_PERCENTILES,
"QUEUE(ns)",
"ns"),
new counter_info(
{"exec.time", "et"}, TASK_EXEC_TIME_NS, COUNTER_TYPE_NUMBER_PERCENTILES, "EXEC(ns)", "ns"),
new counter_info({"throughput", "tp"}, TASK_THROUGHPUT, COUNTER_TYPE_RATE, "THP(#/s)", "#/s"),
new counter_info({"cancelled", "cc"}, TASK_CANCELLED, COUNTER_TYPE_NUMBER, "CANCEL(#)", "#"),
new counter_info({"aio.latency", "al"},
AIO_LATENCY_NS,
COUNTER_TYPE_NUMBER_PERCENTILES,
"AIO.LATENCY(ns)",
"ns"),
new counter_info({"rpc.server.latency", "rpcsl"},
RPC_SERVER_LATENCY_NS,
COUNTER_TYPE_NUMBER_PERCENTILES,
"RPC.SERVER(ns)",
"ns"),
new counter_info({"rpc.server.size.request", "rpcssreq"},
RPC_SERVER_SIZE_PER_REQUEST_IN_BYTES,
COUNTER_TYPE_NUMBER_PERCENTILES,
"RPC.SERVER.SIZE.REQUEST(bytes)",
"bytes"),
new counter_info({"rpc.server.size.response", "rpcssresp"},
RPC_SERVER_SIZE_PER_RESPONSE_IN_BYTES,
COUNTER_TYPE_NUMBER_PERCENTILES,
"RPC.SERVER.SIZE.RESPONSE(bytes)",
"bytes"),
new counter_info({"rpc.client.latency", "rpccl"},
RPC_CLIENT_NON_TIMEOUT_LATENCY_NS,
COUNTER_TYPE_NUMBER_PERCENTILES,
"RPC.CLIENT(ns)",
"ns"),
new counter_info({"rpc.client.timeout", "rpcto"},
RPC_CLIENT_TIMEOUT_THROUGHPUT,
COUNTER_TYPE_RATE,
"TIMEOUT(#/s)",
"#/s"),
new counter_info(
{"task.inqueue", "tiq"}, TASK_IN_QUEUE, COUNTER_TYPE_NUMBER, "InQueue(#)", "#"),
new counter_info({"rpc.dropped", "rdit"},
RPC_DROPPED_IF_TIMEOUT,
COUNTER_TYPE_VOLATILE_NUMBER,
"RPC.DROPPED(#)",
"#")};

// call normal task
static void profiler_on_task_create(task *caller, task *callee)
{
Expand Down Expand Up @@ -371,7 +323,6 @@ void profiler::install(service_spec &)
s_spec_profilers.reset(new task_spec_profiler[s_task_code_max + 1]);
task_ext_for_profiler::register_ext();
message_ext_for_profiler::register_ext();
CHECK_EQ(sizeof(counter_info_ptr) / sizeof(counter_info *), PERF_COUNTER_COUNT);

for (int i = 0; i <= s_task_code_max; i++) {
if (i == TASK_CODE_INVALID)
Expand Down
23 changes: 0 additions & 23 deletions src/runtime/profiler_header.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,29 +50,6 @@ enum perf_counter_ptr_type
PERF_COUNTER_INVALID
};

class counter_info
{
public:
counter_info(const std::vector<std::string> &command_keys,
perf_counter_ptr_type ptr_type,
dsn_perf_counter_type_t counter_type,
const std::string &title,
const std::string &unit)
: keys(command_keys),
counter_ptr_type(ptr_type),
type(counter_type),
title(title),
unit_name(unit)
{
}

std::vector<std::string> keys;
perf_counter_ptr_type counter_ptr_type;
dsn_perf_counter_type_t type;
std::string title;
std::string unit_name;
};

struct task_spec_profiler
{
perf_counter_wrapper ptr[PERF_COUNTER_COUNT];
Expand Down