chore(github): free disk space for github workflows #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Aug 6, 2023
| @@ -31,6 +31,25 @@ exit_if_fail() { | |||
| fi | |||
| } | |||
|
|
|||
| if [ -n ${TEST_OPTS} ]; then | |||
There was a problem hiding this comment.
I‘m planning to remove the run.sh scripts for unit tests in a long term, this change may be a small block for that.
How about define the default value as
DSN_DEFINE_int32(replication,
disk_min_available_space_ratio,
#ifdef PEGASUS_UNIT_TEST
5,
#else
10,
#endif
"if disk available space ratio "
acelyc111
approved these changes
Aug 7, 2023
levy5307
approved these changes
Aug 8, 2023
This was referenced Aug 22, 2023
Closed
empiredan
added a commit
that referenced
this pull request
Aug 28, 2023
#1585 Free more disk space for daily building cpp by referring to #1577. Test has been run manually on [Lint and build regularly](https://github.com/ apache/incubator-pegasus/actions/workflows/regular-build.yml) for the branch [free-regular-disk-space](https://github.com/apache/ incubator-pegasus/tree/free-regular-disk-space).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1576
Free more disk space for github workflows in the following ways:
to 11GB;
disk_min_available_space_ratioby envTEST_OPTSfor some tests;disk_min_available_space_ratiofrom 10 to 5 to some failed testsdue to
SPACE_INSUFFICIENT.