feat(hotkey): add an interface of hotkey capture #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Oct 12, 2020
levy5307
reviewed
Oct 12, 2020
levy5307
reviewed
Oct 13, 2020
levy5307
reviewed
Oct 13, 2020
| @@ -256,9 +284,11 @@ void capacity_unit_calculator::add_check_and_mutate_cu( | |||
| { | |||
| int64_t data_size = 0; | |||
| int64_t check_and_mutate_bytes = 0; | |||
| int64_t key_count = 0; | |||
There was a problem hiding this comment.
uint64_t key_count = mutate_list.size();
hycdong
approved these changes
Oct 13, 2020
levy5307
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hotkey capturing is executed in
capacity_unit_calculator.Both
capture_raw_keyandcapture_hash_keyhave two params:keyweightkey: raw_key or hash_keyweight: In some scenarios, some keys will be counted several times, we can capture these keys just one time.