Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix dameng delete undo fail #6714

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

caohdgege
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

same with SqlServerUndoDeleteExecutor,run set IDENTITY_INSERT around actual undo sql

Ⅱ. Does this pull request fix one issue?

fixes #6713

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes modified the milestones: 1.8.1, 2.2.0 Aug 1, 2024
@funky-eyes funky-eyes changed the title Bugfix: fix dameng delete undo fail bugfix: fix dameng delete undo fail Aug 1, 2024
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/rm-datasource rm-datasource module labels Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.24%. Comparing base (939655a) to head (c57ac34).

Files Patch % Lines
...ta/rm/datasource/undo/dm/DmUndoDeleteExecutor.java 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6714      +/-   ##
============================================
- Coverage     50.25%   50.24%   -0.01%     
  Complexity     5854     5854              
============================================
  Files          1058     1058              
  Lines         36704    36707       +3     
  Branches       4364     4366       +2     
============================================
- Hits          18444    18442       -2     
- Misses        16427    16431       +4     
- Partials       1833     1834       +1     
Files Coverage Δ
...ta/rm/datasource/undo/dm/DmUndoDeleteExecutor.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit d0f8c6f into apache:2.x Aug 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dameng delete sql undo fail
2 participants