Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix][connector][jdbc] fix JDBC split exception #2904

Merged
merged 2 commits into from
Sep 27, 2022
Merged

[hotfix][connector][jdbc] fix JDBC split exception #2904

merged 2 commits into from
Sep 27, 2022
+59 −28

Conversation

ashulin
Copy link
Member

@ashulin ashulin commented Sep 26, 2022 •
edited
Loading

Purpose of this pull request

  1. SplitEnumeratorContext#currentParallelism() is runtime method that will give incorrect results when used in SplitEnumerator#open()
  2. Spark will periodically trigger the checkpoint to close the task. The reader needs to acquire the checkpoint lock to ensure that a single split read is completed.

Check list

@ashulin
Copy link
Member Author

ashulin commented Sep 27, 2022

@hailin0 PTAL

EricJoy2048
EricJoy2048 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@EricJoy2048 EricJoy2048 merged commit 57342c6 into apache:dev Sep 27, 2022
@ashulin ashulin deleted the hotfix/jdbc branch September 28, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 left review comments

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashulin @hailin0 @CalvinKirs @EricJoy2048