Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] [Connector-V2] Add connector-v2 kafka source doc #2953

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

TaoZex
Copy link
Contributor

@TaoZex TaoZex commented Sep 29, 2022

Purpose of this pull request

issue:#2840
Add connector-v2 kafka source and sink doc
sink doc in pr:#2889

Check list

| ----------------- | ------ | -------- | ------------------------ |
| topic | String | yes | - |
| bootstrap.servers | String | yes | - |
| pattern | String | no | false |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String -> boolean?

| consumer.group | String | no | SeaTunnel-Consumer-Group |
| kafka.* | String | no | - |
| common-options | | no | - |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 22 to 28
| topic | String | yes | - |
| bootstrap.servers | String | yes | - |
| pattern | Boolean | no | false |
| consumer.group | String | no | SeaTunnel-Consumer-Group |
| commit_on_checkpoint | Boolean | no | true |
| kafka.* | String | no | - |
| common-options | | no | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check style

Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@CalvinKirs CalvinKirs merged commit ed7a75c into apache:dev Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants