Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][all] change Log to @Slf4j #3001

Merged
merged 7 commits into from
Oct 8, 2022
Merged

[Improve][all] change Log to @Slf4j #3001

merged 7 commits into from
Oct 8, 2022

Conversation

liugddx
Copy link
Member

@liugddx liugddx commented Oct 6, 2022

Purpose of this pull request

This PR contains all the log type substitutions, use @slf4j unified mode.There are no other logical changes here,but it's a big change,so ask the community to review in detail.

Check list

CalvinKirs
CalvinKirs reviewed Oct 6, 2022
View reviewed changes
Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are some unrelated modifications, are you able to restore it? Also, I didn't check if it has been completely replaced

@CalvinKirs CalvinKirs added the chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. label Oct 6, 2022
@liugddx
Copy link
Member Author

liugddx commented Oct 6, 2022

LGTM, but there are some unrelated modifications, are you able to restore it? Also, I didn't check if it has been completely replaced

Done.

EricJoy2048
EricJoy2048 previously approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hailin0
hailin0 reviewed Oct 6, 2022
View reviewed changes
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...ector-flink-druid/src/main/java/org/apache/seatunnel/flink/druid/sink/DruidOutputFormat.java Outdated
"|",
null,
null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.Thank you for your review.

@EricJoy2048 EricJoy2048 removed the chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. label Oct 6, 2022
hailin0
hailin0 previously approved these changes Oct 6, 2022
View reviewed changes
@EricJoy2048
Copy link
Member

Please resolve conflicts.

@liugddx
Copy link
Member Author

liugddx commented Oct 7, 2022

Please resolve conflicts.

Done.

@EricJoy2048
Copy link
Member

Please waiting the CI complete. I will merge it after CI finished.

@liugddx
Copy link
Member Author

liugddx commented Oct 7, 2022

please rerun the CI. @EricJoy2048

@CalvinKirs
Copy link
Member

Regarding Connctor V1, do we still need to make replacements?For me, it doesn't make much sense.

EricJoy2048
EricJoy2048 approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@EricJoy2048 EricJoy2048 merged commit 6016100 into apache:dev Oct 8, 2022
@liugddx liugddx deleted the improve-log branch October 8, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@hailin0 hailin0 hailin0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liugddx @EricJoy2048 @CalvinKirs @hailin0