-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2-Clickhouse] Clickhouse Source random use host when config multi-host #3108
Conversation
…when config multi-host
…when config multi-host
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.../main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/source/ClickhouseSource.java
Outdated
Show resolved
Hide resolved
@@ -55,6 +55,7 @@ public class ClickhouseSource implements SeaTunnelSource<SeaTunnelRow, Clickhous | |||
private List<ClickHouseNode> servers; | |||
private SeaTunnelRowType rowTypeInfo; | |||
private String sql; | |||
private final ThreadLocalRandom threadLocalRandom = ThreadLocalRandom.current(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
call directly inside the method
…/apache/seatunnel/connectors/seatunnel/clickhouse/source/ClickhouseSource.java Co-authored-by: hailin0 <hailin088@gmail.com>
…when config multi-host
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The ci failed, please fix it first. thanks |
…when config multi-host
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for completion of CI.
…when config multi-host (apache#3108)
…when config multi-host (apache#3108)
Purpose of this pull request
#2806
Check list
New License Guide