From babe66e1fee34849282b86c1e1708a9ba3b6d92e Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Mon, 21 Nov 2022 01:17:01 -0800 Subject: [PATCH] vuln-fix: Temporary File Information Disclosure (#1007) This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18 Co-authored-by: Moderne Co-authored-by: Moderne --- .../stormcrawler/parse/filter/DebugParseFilter.java | 3 ++- .../stormcrawler/aws/bolt/CloudSearchIndexerBolt.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/com/digitalpebble/stormcrawler/parse/filter/DebugParseFilter.java b/core/src/main/java/com/digitalpebble/stormcrawler/parse/filter/DebugParseFilter.java index b5ceebe34..cc01589e6 100644 --- a/core/src/main/java/com/digitalpebble/stormcrawler/parse/filter/DebugParseFilter.java +++ b/core/src/main/java/com/digitalpebble/stormcrawler/parse/filter/DebugParseFilter.java @@ -20,6 +20,7 @@ import java.io.File; import java.io.IOException; import java.io.OutputStream; +import java.nio.file.Files; import java.util.Map; import org.apache.commons.io.FileUtils; import org.apache.xml.serialize.XMLSerializer; @@ -46,7 +47,7 @@ public void filter(String URL, byte[] content, DocumentFragment doc, ParseResult @Override public void configure(@NotNull Map stormConf, @NotNull JsonNode filterParams) { try { - File outFile = File.createTempFile("DOMDump", ".xml"); + File outFile = Files.createTempFile("DOMDump", ".xml").toFile(); os = FileUtils.openOutputStream(outFile); } catch (IOException e) { e.printStackTrace(); diff --git a/external/aws/src/main/java/com/digitalpebble/stormcrawler/aws/bolt/CloudSearchIndexerBolt.java b/external/aws/src/main/java/com/digitalpebble/stormcrawler/aws/bolt/CloudSearchIndexerBolt.java index 8ba012267..07949c79b 100644 --- a/external/aws/src/main/java/com/digitalpebble/stormcrawler/aws/bolt/CloudSearchIndexerBolt.java +++ b/external/aws/src/main/java/com/digitalpebble/stormcrawler/aws/bolt/CloudSearchIndexerBolt.java @@ -41,6 +41,7 @@ import java.io.IOException; import java.io.InputStream; import java.nio.charset.StandardCharsets; +import java.nio.file.Files; import java.text.ParseException; import java.text.SimpleDateFormat; import java.util.ArrayList; @@ -349,7 +350,7 @@ public void sendBatch() { if (dumpBatchFilesToTemp) { try { - File temp = File.createTempFile("CloudSearch_", ".json"); + File temp = Files.createTempFile("CloudSearch_", ".json").toFile(); FileUtils.writeByteArrayToFile(temp, bb); LOG.info("Wrote batch file {}", temp.getName()); // ack the tuples