Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning_text to BaseMetric model #3389

Closed
mistercrunch opened this issue Aug 29, 2017 · 0 comments
Closed

Add warning_text to BaseMetric model #3389

mistercrunch opened this issue Aug 29, 2017 · 0 comments
Labels
good first issue Good first issues for new contributors

Comments

@mistercrunch
Copy link
Member

mistercrunch commented Aug 29, 2017 •
edited
Loading

In an effort to inform users of when they are using sketches (probabilistic metrics) or any other metrics with caveats really, let's add a way to store and expose that metadata.

  • add warning_text to BaseMetric
  • generate db migration script to add that column
  • make sure markdown is supported in that context
  • surface in UI in MetricOption component as a fa-info-circle with tooltip exposing the context of the warning
  • [optional/unclear] add an overlay inside the visualization itself, perhaps in the upper right corner, subtle but visible
@michellethomas michellethomas mentioned this issue Sep 19, 2017
Merged
@mistercrunch mistercrunch added the good first issue Good first issues for new contributors label Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good first issues for new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mistercrunch