-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump pypi cryptography from 2.4.2 to 3.2.1 #11511
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11511 +/- ##
==========================================
- Coverage 66.57% 62.18% -4.39%
==========================================
Files 873 873
Lines 41777 41771 -6
Branches 3826 3826
==========================================
- Hits 27814 25977 -1837
- Misses 13861 15615 +1754
- Partials 102 179 +77
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -75,7 +75,7 @@ def get_git_sha(): | |||
"colorama", | |||
"contextlib2", | |||
"croniter>=0.3.28", | |||
"cryptography>=2.4.2", | |||
"cryptography>=3.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could potentially add , <4
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're pinned under requirements/
I don't think it's necessary. I'd pin if we'd know for sure that there's a backward-incompatible that is actually affecting us. Many times despite semver saying we may be affected, we're actually not.
BTW, just a thought but we may want to reconsider |
SUMMARY
title ^^^