feat(alerts/reports): delete and bulk delete actions #12053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12053 +/- ##
==========================================
- Coverage 63.81% 63.76% -0.06%
==========================================
Files 956 956
Lines 46845 46945 +100
Branches 4590 4597 +7
==========================================
+ Hits 29895 29933 +38
- Misses 16766 16828 +62
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nytai
force-pushed
the
tai/alerts-delete-flow
branch
from
2a67b09 to
67b436b
Compare
nytai
commented
Dec 15, 2020
| @@ -66,7 +66,7 @@ | |||
| "@data-ui/sparkline": "^0.0.84", | |||
| "@emotion/core": "^10.0.35", | |||
| "@superset-ui/chart-controls": "^0.15.13", | |||
| "@superset-ui/core": "^0.15.13", | |||
| "@superset-ui/core": "^0.15.17", | |||
There was a problem hiding this comment.
update to take advantage of new rison requestType for makeApi
nytai
force-pushed
the
tai/alerts-delete-flow
branch
from
67b436b to
74336d1
Compare
riahk
approved these changes
Dec 15, 2020
riahk
reviewed
Dec 15, 2020
| @@ -52,7 +52,7 @@ export type AlertObject = { | |||
| database?: MetaObject; | |||
| description?: string; | |||
| grace_period?: number; | |||
| id?: number; | |||
| id: number; | |||
There was a problem hiding this comment.
Does this not throw a ts error when creating alerts?
There was a problem hiding this comment.
I updated the state type to be Partial<AlertObject> so that we can store incomplete AlertObjects in state.
willbarrett
approved these changes
Dec 16, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
TEST PLAN
ADDITIONAL INFORMATION