[js] version js file names using webpack chunkhash #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascott
force-pushed
the
alanna-webpack-file-naming
branch
from
3b6e09d
to
f8b4c96
Compare
|
Very nice. Happy to see this! LGTM |
mistercrunch
approved these changes
Jun 12, 2017
ascott
force-pushed
the
alanna-webpack-file-naming
branch
from
52328fb
to
9412978
Compare
added 3 commits
June 12, 2017 22:48
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Jun 13, 2017
* get compiled js file names * make manifest available as template var * use script src directly to avoid flash of unstyled content in the case of csstheme.js * linting * attempt to fix tests * exception * print the path when no manifest file found * handle case when manifest.json is not present for some reason, or in the case of tests
|
In dev mode, the |
|
I don't have this problem in dev mode. It was an issue inn the master branch for a little while recently but it's fixed now. Can you rebase? |
|
@mistercrunch Thanks for your reply. It works. Great job. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr introduces automatic js filename versioning so we don't have to rely on updating the package.json version to make sure changed js files get their cache busted.
@mistercrunch @graceguo-supercat