Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'refresh_immune_slices' #2974

Merged
merged 3 commits into from
Aug 2, 2017
Merged

Allow 'refresh_immune_slices' #2974

merged 3 commits into from
Aug 2, 2017

Conversation

ratb3rt
Copy link

@ratb3rt ratb3rt commented Jun 15, 2017

Ref #2958 , add a 'refresh_immune_slices' property to dashboards. Any slice ids listed will not be included in an automatic dashboard refresh.
I chose to exclude rather than include to be consist with filter_immune_slices.

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general except that the setting name is not specific enough, and you should add an entry in the docs/faq.rst

@mistercrunch
Copy link
Member

Also you can make sure you pass the build before sending in the PR by setting up travis-ci against your fork. It's really easy to setup and will run a build for each new push on your repo.

Copy link
Author

@ratb3rt ratb3rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to 'timed_refresh_immune_slices' in latest commit, added usage to faq.rst

@ratb3rt
Copy link
Author

ratb3rt commented Jun 27, 2017

Any additional reviews on this PR?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 69.3% when pulling db7a64d on RichRadics:refresh_immune into 90592d3 on apache:master.

1 similar comment
@coveralls
Copy link

coveralls commented Aug 2, 2017

Coverage Status

Coverage increased (+0.002%) to 69.3% when pulling db7a64d on RichRadics:refresh_immune into 90592d3 on apache:master.

@mistercrunch mistercrunch merged commit 163f4e3 into apache:master Aug 2, 2017
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1 labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants