Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explore] add collapsible Control sections #3354

Merged
merged 1 commit into from
Aug 22, 2017

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Aug 22, 2017

screen shot 2017-08-21 at 6 19 05 pm

The left panel of the explore view has become crowded and overwhelming overtime. This PR adds functionality to collapse the control sections, and sets most sections to be collapse by default as the explore view opens up.
  • "indent" panel body in control groups
  • breakdown Query section for most viz
  • bring filters to the top, under Query section
  • collapse most sections by default
  • removed confusing outdated description for Filter section

The left panel of the explore view has become crowded and overwhelming
overtime. This PR adds functionality to collapse the control sections,
and sets most sections to be collapse by default as the explore view
opens up.

* breakdown `Query` section for most viz
* bring filters to the top, under Query section
* collapse most sections by default
* removed confusing outdated description for Filter section
@coveralls
Copy link

coveralls commented Aug 22, 2017

Coverage Status

Coverage remained the same at 69.39% when pulling 39dbf97 on mistercrunch:collapse into 1fda6f0 on apache:master.

@graceguo-supercat
Copy link

LGTM

@mistercrunch mistercrunch merged commit 670ba5d into apache:master Aug 22, 2017
@mistercrunch mistercrunch deleted the collapse branch August 22, 2017 23:17
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants