Allowing to set the sort order during query with "group by" #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage increased (+0.004%) to 69.121% when pulling baaa4a1e330ec628db05786beea50bc838b4edb9 on tc-dc:fmenges/order_direction into 3dfdde1 on apache:master. |
|
LGTM but please rebase (fixed the build on |
fabianmenges
force-pushed
the
fmenges/order_direction
branch
from
baaa4a1
to
640c953
Compare
mistercrunch
requested changes
Sep 12, 2017
| @@ -137,6 +137,9 @@ def query_obj(self): | |||
| row_limit = int( | |||
| form_data.get("row_limit") or config.get("ROW_LIMIT")) | |||
|
|
|||
| # default order direction | |||
| order_desc = form_data.get("order_desc", True) | |||
There was a problem hiding this comment.
I feel like there's a control (in controls.jsx) missing in this PR (?)
|
I'm actually working on something related, merged to build around this. |
|
K, sounds good. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run a "group by" query with a "series limit" you can specify the "sort by" metric but not the sort order. In the following example you can see that you get the top 5 names. There is currently no way to look at the bottom 5 names. (sort order is hard coded to desc).
This change includes the backend changes to add this functionality. I'm happy to help on the front end as well.