Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultSort should be false when no sort is necessary #3693

Merged
merged 1 commit into from
Oct 23, 2017
Merged

defaultSort should be false when no sort is necessary #3693

merged 1 commit into from
Oct 23, 2017

Conversation

michellethomas
Copy link
Contributor

In the time table viz I start off by setting defaultSort to null when it should be false. Reactable has a few checks for sortBy !== false when updating sort, which causes issues if defaultSort not false (but null).

@coveralls
Copy link

coveralls commented Oct 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 70.757% when pulling f9d00b7 on michellethomas:timetable_fix_sort_false into e121a85 on apache:master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 70.757% when pulling f9d00b7 on michellethomas:timetable_fix_sort_false into e121a85 on apache:master.

@graceguo-supercat
Copy link

LGTM!

@graceguo-supercat graceguo-supercat merged commit fa07b8d into apache:master Oct 23, 2017
michellethomas added a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@michellethomas
defaultSort should be false when no sort is necessary (apache#3693)
d33e524
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.5 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michellethomas @coveralls @graceguo-supercat @mistercrunch