Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump react-bootstrap version #3723

Merged
merged 1 commit into from
Oct 27, 2017
Merged

bump react-bootstrap version #3723

merged 1 commit into from
Oct 27, 2017

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Oct 26, 2017 •
edited
Loading

  1. fix the exports is not defined error
  2. per jordan's suggestion, update .babelrc only use airbnb presets

bump react-bootstrap version
5162902 
1. avoid exports is not defined error
2. per jordan's suggestion, update .babelrc only use airbnb presets
@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.352% when pulling 5162902 on graceguo-supercat:gg-UpReactBootstrapVersion into 9432ea8 on apache:master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 26, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 71.352% when pulling 5162902 on graceguo-supercat:gg-UpReactBootstrapVersion into 9432ea8 on apache:master.

fabianmenges
fabianmenges approved these changes Oct 26, 2017
View reviewed changes
Copy link
Contributor

@fabianmenges fabianmenges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat graceguo-supercat merged commit cbd0107 into apache:master Oct 27, 2017
@graceguo-supercat graceguo-supercat deleted the gg-UpReactBootstrapVersion branch October 30, 2017 20:25
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@michellethomas
bump react-bootstrap version (apache#3723)
ccc2a26 
1. avoid exports is not defined error
2. per jordan's suggestion, update .babelrc only use airbnb presets
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.5 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianmenges fabianmenges fabianmenges approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@graceguo-supercat @coveralls @fabianmenges @mistercrunch