Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[slice] Removing unused legacy argument #3838

Merged
merged 1 commit into from
Nov 12, 2017
Merged

[slice] Removing unused legacy argument #3838

merged 1 commit into from
Nov 12, 2017

Conversation

john-bodley
Copy link
Member

This PR removes the unused legacy url_params_multidict argument from the Slice.get_viz(...) method.

@coveralls
Copy link

coveralls commented Nov 12, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 71.517% when pulling de96df0 on john-bodley:john-bodley-fix-get-viz-signature into 4d48d5d on apache:master.

@mistercrunch mistercrunch merged commit d908e48 into apache:master Nov 12, 2017
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@john-bodley @michellethomas
[slice] Removing deprecated argument (apache#3838)
52dd513
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@john-bodley @mistercrunch
[slice] Removing deprecated argument (apache#3838)
7aba973
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-bodley @coveralls @mistercrunch