Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the build's linting errors #3887

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Nov 16, 2017

@john-bodley

master has new linting rules, PRs got merged with lint that was ok at
branching but not ok on master anymore

We should probably force all PRs to rebase against master otherwise they will break the build upon merge.

master has new linting rules, PRs got merged with lint that was ok at
branching but not ok in masert anymore
@hughhhh
Copy link
Member

hughhhh commented Nov 16, 2017

👍

@mistercrunch mistercrunch merged commit e65aba3 into apache:master Nov 16, 2017
@mistercrunch mistercrunch deleted the fix_the_build branch November 16, 2017 19:18
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
master has new linting rules, PRs got merged with lint that was ok at
branching but not ok in masert anymore
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
master has new linting rules, PRs got merged with lint that was ok at
branching but not ok in masert anymore
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants