fix the schema-fetching problem for impala in sql_lab #3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
requested changes
Nov 20, 2017
superset/models/core.py
Outdated
| @@ -726,7 +726,8 @@ def all_view_names(self, schema=None, force=False): | |||
| return views | |||
|
|
|||
| def all_schema_names(self): | |||
| return sorted(self.inspector.get_schema_names()) | |||
| schemas = sorted(self.db_engine_spec.get_schema_names(self.inspector)) | |||
There was a problem hiding this comment.
no need for the affectation, just return directly
superset/db_engine_specs.py
Outdated
| @@ -148,6 +148,10 @@ def adjust_database_uri(cls, uri, selected_schema): | |||
| def patch(cls): | |||
| pass | |||
|
|
|||
| @classmethod | |||
| def get_schema_names(cls, inspector): | |||
| return sorted(inspector.get_schema_names()) | |||
There was a problem hiding this comment.
The code calling the function is already sorting, no need to sort here.
mistercrunch
approved these changes
Nov 21, 2017
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* fix the schema-fetching problem for impala in sql_lab * delete redundant print * remove blank lines... * minior corrections
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* fix the schema-fetching problem for impala in sql_lab * delete redundant print * remove blank lines... * minior corrections
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works for [thrift==0.9.3|0.10.0].