Workaround pandas bug in datetimes with time zones #3910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolkedebruin
force-pushed
the
issue-1229
branch
2 times, most recently
from
3c8cf6f
to
7605648
Compare
A bug in to_dict(orient="records") in pandas/core/frame.py prevents datetimes with time zones to be worked with. This works around the issue in superset by re-implementing the logic of pandas in the correct way. Until pandas fixes the issue this code should stay. pandas-dev/pandas#18372 This closes apache#1929
bolkedebruin
force-pushed
the
issue-1229
branch
from
7605648
to
e95e3ef
Compare
|
Greetings, happy to see you over on this repo! |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
A bug in to_dict(orient="records") in pandas/core/frame.py prevents datetimes with time zones to be worked with. This works around the issue in superset by re-implementing the logic of pandas in the correct way. Until pandas fixes the issue this code should stay. pandas-dev/pandas#18372 This closes apache#1929
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
A bug in to_dict(orient="records") in pandas/core/frame.py prevents datetimes with time zones to be worked with. This works around the issue in superset by re-implementing the logic of pandas in the correct way. Until pandas fixes the issue this code should stay. pandas-dev/pandas#18372 This closes apache#1929
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in to_dict(orient="records") in pandas/core/frame.py prevents
datetimes with time zones to be worked with. This works around the
issue in superset by re-implementing the logic of pandas in the
correct way. Until pandas fixes the issue this code should stay.
pandas-dev/pandas#18372
This closes #1929
cc: @tfellison @rumbin @xrmx