Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an "Edit Mode" to Dashboard view #3940

Merged
merged 4 commits into from
Nov 28, 2017
Merged

Add an "Edit Mode" to Dashboard view #3940

merged 4 commits into from
Nov 28, 2017

Conversation

mistercrunch
Copy link
Member

stxstantp0
What changes when toggling between edit/view mode:

  • can't edit title
  • can't remove slices
  • can't move slices
  • only actions available: "force refresh" and "set autorefresh"

@graceguo-supercat
Copy link

apply_filter

Hi Max, thanks for adding 'Edit Mode'. I have a question, please see the attached example:
User has a dashboard with a filter-box, which can apply filter to all slices. If they changed filter, they can also saveas/overwrite the dashboard with changed filter value.
So In this use case, applying filter and save dashboard with different filter value, is it to be in a edit mode?

@mistercrunch
Copy link
Member Author

Right, we need to allow for "Save As" in view mode. I had missed that. Let me add it back.

Note that changing the filter does not trigger the "has changed" notification.

@mistercrunch
Copy link
Member Author

@graceguo-supercat I addressed your comment

@graceguo-supercat
Copy link

graceguo-supercat commented Nov 28, 2017 •
edited
Loading

@mistercrunch It looks good to me. Only 1 question to clarify: all of the components' editMode default value is false, but dashboard's initial state is set editMode be true. is it an intended design? thank you.

@mistercrunch
Copy link
Member Author

mistercrunch commented Nov 28, 2017 •
edited
Loading

@graceguo-supercat good point, I meant to set editMode's default to false everywehre, let me fix that.

graceguo-supercat
graceguo-supercat approved these changes Nov 28, 2017
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat graceguo-supercat merged commit d9fda34 into apache:master Nov 28, 2017
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch @michellethomas
Add an "Edit Mode" to Dashboard view (apache#3940)
5ee2588 
* Add a togglable edit mode to dashboard

* Submenu for controls

* Allowing 'Save as' outside of editMode

* Set editMode to false as default
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch
Add an "Edit Mode" to Dashboard view (apache#3940)
005cc76 
* Add a togglable edit mode to dashboard

* Submenu for controls

* Allowing 'Save as' outside of editMode

* Set editMode to false as default
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistercrunch @graceguo-supercat