Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[time series table] visual improvements #3957

Merged
merged 2 commits into from
Dec 1, 2017
Merged

[time series table] visual improvements #3957

merged 2 commits into from
Dec 1, 2017

Conversation

williaster
Copy link
Contributor

@graceguo-supercat @michellethomas
cc @mistercrunch

This PR adds several visual improvements to the time series table 🚀

  • improves positioning of tooltip by updating to @data-ui/sparkline@0.0.49
  • adds partial tooltip opacity also enabled by @data-ui/sparkline@0.0.49
  • uses a more neutral #767676 for the sparkline color so it doesn't clash with the red/blue
  • adds ability to customize the format of the sparkline date
  • removes grey background from table rows on hover
  • font size increased from 12px to 14px
  • color encoding is made more apparent and normalized for area through cell coloring (vs just the number)

Before
image

After
image

Gif
updated-timeseries-table

@mistercrunch
Copy link
Member

Side note: I've been thinking that we could parameterize the font size. When there's a sparkline there's plenty of room to bring in bigger digits. Could also allow users to add emphasis on some of the columns.

@mistercrunch mistercrunch self-requested a review November 30, 2017 04:20
mistercrunch
mistercrunch approved these changes Nov 30, 2017
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistercrunch mistercrunch merged commit 76a2f95 into apache:master Dec 1, 2017
@williaster williaster deleted the chris--ttt-time-table-tweaks branch December 1, 2017 20:58
@williaster
Copy link
Contributor Author

wohoo! thanks 🎉

michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@williaster @michellethomas
[time series table] visual improvements (apache#3957)
92fb628 
* [time series table] visual improvements

* [time series table] don't set cell color if text color isn't set
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@williaster @mistercrunch
[time series table] visual improvements (apache#3957)
ad9c72f 
* [time series table] visual improvements

* [time series table] don't set cell color if text color isn't set
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williaster @mistercrunch