Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] fix a filter refresh bug and add Test #3967

Merged
merged 1 commit into from
Dec 1, 2017
Merged

[Dashboard] fix a filter refresh bug and add Test #3967

merged 1 commit into from
Dec 1, 2017

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Nov 30, 2017 •
edited
Loading

Fixes a few dashboard filters related bugs:

  1. when apply filter, should not refresh filter slice.
  2. when remove filter-box slice, should remove the associated filter from dashboard meta data
  3. fix a dashboard reducer bug, after slice title update, dashboard's state was wrong.
  4. remove loadPreSelectFilters from Dashboard. We already parsed filter data during redux store initialization.
  5. setup a test suit for Dashboard component.

@mistercrunch
Copy link
Member

LGTM

@graceguo-supercat graceguo-supercat merged commit 0284565 into apache:master Dec 1, 2017
@graceguo-supercat graceguo-supercat deleted the gg-DashboardFilterFix branch December 4, 2017 18:35
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@michellethomas
[Dashboard] fix a filter refresh bug and add Test (apache#3967)
4ed6382
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
[Dashboard] fix a filter refresh bug and add Test (apache#3967)
594f461
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graceguo-supercat @mistercrunch