Fix for SQL editor throwing can't deserialize google.cloud.bigquery._helpers.Row with BigQuery #4071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elpers.Row with BigQuery
|
Please lint the code, you can look at the travis logs to debug. |
|
Travis is failing with How can this be fixed in Travis? |
|
I bet flake8 complains because you are importing a 'private' module. |
|
@fabianmenges, yes google.cloud.bigquery._helpers.Row is imported within BQEngineSpec. |
|
try |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
…helpers.Row with BigQuery (apache#4071) * fix for SQL editor throwing cant deserialize google.cloud.bigquery._helpers.Row with BigQuery * linted code * disable pylint import error of bigquery row * fixed spacing issue before inline-comment
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…helpers.Row with BigQuery (apache#4071) * fix for SQL editor throwing cant deserialize google.cloud.bigquery._helpers.Row with BigQuery * linted code * disable pylint import error of bigquery row * fixed spacing issue before inline-comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is as per discussion on #4028
Please review.
@xrmx, Sorry for the delayed response to comment on #4034. As we were making changes to master branch of our fork of superset, that changes were getting added to the above mentioned pull request as I did a pull request from that master. I don't know git enough to prevent that from happening, so creating this new request from a different branch.