Fix USA's state geojson for 'Country Map' visualization #4121
Conversation
|
🚢 |
There was a problem hiding this comment.
I tested this change with 0.22, but it unfortunately does not fix the problem. From what I can see, the issue is that the file does not use the official ISO 3166-2 codes as the old country map did. For example, the code being used for Georgia is GA rather than US-GA. The old map format worked with US-GA, but this one does not. If my assumption is correct that all codes need the country dash prefix, then I believe the only remaining change would be to add the "US-" in front of all ISO codes in the file. For reference, please see http://www.statemaster.com/graph/ide_iso_316_cod_sor_by_nam_sta-us-codes-sorted-name-states
|
Yeah I have to admit I considered both options while writing the PR. I think it's much more common to have the 2-letter code in databases for US states, but it's true that |
Turns out the ISO codes were missing from the geojson file, this adds it and uses human-readable indents.
mistercrunch
force-pushed
the
fix_usa_geojson
branch
from
ebfa198
to
833649b
Compare
mistercrunch
force-pushed
the
fix_usa_geojson
branch
from
dc4fbe0
to
65be83b
Compare
* Fix USA's state geojson for 'Country Map' visualization Turns out the ISO codes were missing from the geojson file, this adds it and uses human-readable indents. * using proper ISO codes * Linting New linting rules started applying, I'm guessing a new version of pylint?
* Fix USA's state geojson for 'Country Map' visualization Turns out the ISO codes were missing from the geojson file, this adds it and uses human-readable indents. * using proper ISO codes * Linting New linting rules started applying, I'm guessing a new version of pylint?
mistercrunch
added
🏷️ bot
Turns out the ISO codes were missing from the geojson file, this adds it
and uses human-readable indents.
fixes #4112