Minor fixes to sunburst #4349
Merged
Minor fixes to sunburst #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
approved these changes
Feb 6, 2018
superset/viz.py
Outdated
| self.form_data['metric'], self.form_data['secondary_metric']] | ||
| fd = self.form_data | ||
| qry['metrics'] = [fd['metric']] | ||
| sm = fd.get('secondary_metric') |
There was a problem hiding this comment.
Nit: I would use secondary_metric here instead of sm, in order to be consistent with the get_data method.
mistercrunch
force-pushed
the
sunburst
branch
from
57d86c3
to
988d148
Compare
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Minor fixes to sunburst closes apache#4340 * nit
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Minor fixes to sunburst closes apache#4340 * nit
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4340 as it now accepts and empty secondary metric