Pass in cache timeout for async queries #4436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreythewang
force-pushed
the
jeffreyw/cache_timeout
branch
from
8d182d4
to
8d6123e
Compare
|
LGTM |
| cache_timeout = database.cache_timeout | ||
| if cache_timeout is None: | ||
| cache_timeout = config.get('CACHE_DEFAULT_TIMEOUT', 0) | ||
| results_backend.set(key, utils.zlib_compress(json_payload), cache_timeout) |
There was a problem hiding this comment.
Oh interesting. FYI we use the s3 caching as a result backend which doesn't really support timeout, so this won't matter on our end, but for people using other results backend that's probably the desired behavior. https://github.com/bkyryliuk/s3werkzeugcache/blob/master/s3cache/s3cache.py
There was a problem hiding this comment.
Yeah I figured that may have been the case.
To give some more context on our end, we use twemcache as our results backend, and, depending on which client is used, defaulting to None can cause issues.
To conclude, since the werkzeug.contrib.cache.BaseCache's set method includes a timeout field, it should be passed down through here as well.
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Pass in cache timeout for async queries * Default cache timeout to 0 if default env var is not set * check for 0 timeout
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Pass in cache timeout for async queries * Default cache timeout to 0 if default env var is not set * check for 0 timeout
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows cache timeout for asynchronous queries to be tuned on a per-database level.
@mistercrunch