Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve default placeholder text on SelectControl #4442

Merged
merged 1 commit into from
Feb 16, 2018
Merged

Improve default placeholder text on SelectControl #4442

merged 1 commit into from
Feb 16, 2018

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Feb 16, 2018 •
edited
Loading

before

screen shot 2018-02-15 at 9 57 06 pm

after

screen shot 2018-02-15 at 9 56 02 pm

graceguo-supercat
graceguo-supercat approved these changes Feb 16, 2018
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistercrunch mistercrunch merged commit 88e91e6 into apache:master Feb 16, 2018
@mistercrunch mistercrunch deleted the options branch February 16, 2018 23:17
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch @michellethomas
Improve default placeholder text on SelectControl (apache#4442)
707a290
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch
Improve default placeholder text on SelectControl (apache#4442)
41e2fd8
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistercrunch @graceguo-supercat