Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for 48 columns dashboard, adjust default size for newly added slices #4446

Merged
merged 1 commit into from
Feb 19, 2018
Merged

for 48 columns dashboard, adjust default size for newly added slices #4446

merged 1 commit into from
Feb 19, 2018

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Feb 16, 2018 •
edited
Loading

screen shot 2018-02-16 at 11 49 22 am

  • When user added new slice into dashboard, its default size was based on 12 columns layout. now we have 48 columns.
  • adjust default size for newly added slices.
  • append newly added slices at the bottom of existed slices.
  • if user added multiple slices, default set 3 slices per row.

@mistercrunch @michellethomas

@mistercrunch
Copy link
Member

Ooops. I had missed this. Thanks for picking up after me :)

LGTM

@graceguo-supercat graceguo-supercat merged commit 5768a1f into apache:master Feb 19, 2018
@graceguo-supercat graceguo-supercat deleted the gg-FixNewAddedSliceSizeAndLayout branch February 21, 2018 19:15
mistercrunch pushed a commit that referenced this pull request Feb 22, 2018
@mistercrunch
for 48 columns layout, adjust default size and layout for newly added…
f99c22a 
… slices (#4446)

(cherry picked from commit 5768a1f)
@graceguo-supercat graceguo-supercat mentioned this pull request Mar 1, 2018
Merged
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@michellethomas
for 48 columns layout, adjust default size and layout for newly added…
515365e 
… slices (apache#4446)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
for 48 columns layout, adjust default size and layout for newly added…
d81245b 
… slices (apache#4446)
@mistercrunch mistercrunch added 🍒 0.23.0 🍒 0.23.1 🍒 0.23.2 🍒 0.23.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch
for 48 columns layout, adjust default size and layout for newly added…
252dced 
… slices (apache#4446)

(cherry picked from commit 5768a1f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch Awaiting requested review from mistercrunch

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels v0.23 🍒 0.23.0 🍒 0.23.1 🍒 0.23.2 🍒 0.23.3 🚢 0.24.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graceguo-supercat @mistercrunch