[Explore] Chart style options get their own tab #4482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
force-pushed
the
gabe_chart_options_hidden_tab
branch
from
184c33c
to
81d5643
Compare
|
Future work: |
|
Nice! I've been meaning to do something like this for way too long. |
gabe-lyons
force-pushed
the
gabe_chart_options_hidden_tab
branch
2 times, most recently
from
68bfc30
to
95b5e9d
Compare
|
closes #4296 |
|
@GabeLoins the build is failing because of some js lint issues |
gabe-lyons
force-pushed
the
gabe_chart_options_hidden_tab
branch
from
95b5e9d
to
1c0d620
Compare
|
@michellethomas PTAL when you have the chance, rearranged so we depend entirely on |
|
this lgtm 💯 |
gabe-lyons
force-pushed
the
gabe_chart_options_hidden_tab
branch
3 times, most recently
from
fc07846
to
e87e3a4
Compare
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and then
This way we can keep style configurations out of the way of data configurations, while also making it easier to see all the style configurations in one place!
Open questions: what should the names of these tabs be?
test plan:
reviewers:
@michellethomas @mistercrunch @graceguo-supercat