Fix how the annotation layer interpretes the timestamp string without… #4511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… timezone info; use it as UTC
ghost
mentioned this pull request
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
… timezone info; use it as UTC (apache#4511)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
… timezone info; use it as UTC (apache#4511)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… timezone info; use it as UTC
The Table type of viz gets timestamp as string, and it can be problematic when the string has no timezone info. Date in Javascript interprets it as local, which is different from how the rest of the code treats it, i.e. libraries that viz.py is using in order to get payload interprets the same thing as UTC.
@fabianmenges