Added new exception class and start of better exception/error handling #4514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
changed the title
mistercrunch
reviewed
Mar 6, 2018
superset/exceptions.py
Outdated
| from __future__ import unicode_literals | ||
|
|
||
|
|
||
| class NoDataException(Exception): |
There was a problem hiding this comment.
This should derive superset/utils/SupersetException, we should have all exception in the same module, whether it's still utils or moving it to exceptions.py works for me as well.
Codecov Report
@@ Coverage Diff @@
## master #4514 +/- ##
==========================================
+ Coverage 71.17% 71.18% +<.01%
==========================================
Files 187 188 +1
Lines 14809 14824 +15
Branches 1085 1085
==========================================
+ Hits 10540 10552 +12
- Misses 4266 4269 +3
Partials 3 3
Continue to review full report at Codecov.
|
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
apache#4514) * rebase and linting * change back * wip * fixed broken test * fix flake8 * fix test
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
apache#4514) * rebase and linting * change back * wip * fixed broken test * fix flake8 * fix test
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receiving 500s for client errors from geovis i think a
No Dataresponse shouldn't be a 500 code since its client error and want to throw 400 status. Also lay work for better error throwing moving forward.@mistercrunch @betodealmeida