Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evelynturner/annotation timezone fix2 #4550

Merged

Conversation

ghost
Copy link

@ghost ghost commented Mar 6, 2018

Forgot to make the UTC change for Interval annotation layer as well

Reference: #4511

@ghost ghost force-pushed the evelynturner/annotation-timezone-fix2 branch from 03e1059 to ad2b9e2 Compare March 6, 2018 21:44
@codecov-io
Copy link

codecov-io commented Mar 6, 2018

Codecov Report

Merging #4550 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4550   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files         187      187           
  Lines       14780    14780           
  Branches     1083     1083           
=======================================
  Hits        10513    10513           
  Misses       4264     4264           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e780e4...ad2b9e2. Read the comment docs.

Copy link
Contributor

@jeffreythewang jeffreythewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mistercrunch mistercrunch merged commit 42ebcaa into apache:master Mar 8, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* Fix how the annotation layer interpretes the timestamp string without timezone info; use it as UTC

* Fix how the Interval annotation layer interpretes the timestamp string without timezone info; use it as UTC
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Fix how the annotation layer interpretes the timestamp string without timezone info; use it as UTC

* Fix how the Interval annotation layer interpretes the timestamp string without timezone info; use it as UTC
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants