[cache] Ensuring that the datasource UID is defined #4573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Mar 8, 2018
superset/viz.py
Outdated
| cache_dict[k] = self.form_data.get(k) | ||
|
|
||
| cache_dict['datasource'] = self.form_data.get( |
There was a problem hiding this comment.
@mistercrunch I don't know if this should simply be cache_dict['datasource'] = self.datasource.uid instead.
There was a problem hiding this comment.
either should work, but cache_dict['datasource'] = self.datasource.uid is simpler
Codecov Report
@@ Coverage Diff @@
## master #4573 +/- ##
==========================================
+ Coverage 71.18% 71.18% +<.01%
==========================================
Files 189 189
Lines 14845 14846 +1
Branches 1086 1086
==========================================
+ Hits 10567 10568 +1
Misses 4275 4275
Partials 3 3
Continue to review full report at Codecov.
|
john-bodley
force-pushed
the
john-bodley-cache-fix-datasource-uid
branch
from
621db52
to
26257d9
Compare
|
lgtm |
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Mar 13, 2018
…-datasource-uid [cache] Ensuring that the datasource UID is defined (cherry picked from commit de44098)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…-datasource-uid [cache] Ensuring that the datasource UID is defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mistercrunch whist testing in production we noticed that we were getting cache key misses as it turned out the form data from the
warm_up_cacheAPI endpoint lacked the datasource value which is defined as the UID.