Only show overlay if container is set #4601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is broken, the width is too big. Will fix. |
Codecov Report
@@ Coverage Diff @@
## master #4601 +/- ##
==========================================
- Coverage 71.18% 71.17% -0.01%
==========================================
Files 189 189
Lines 14845 14846 +1
Branches 1086 1087 +1
==========================================
Hits 10567 10567
- Misses 4275 4276 +1
Partials 3 3
Continue to review full report at Codecov.
|
betodealmeida
changed the title
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Pass width in props * Only load overlay if container is set
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Pass width in props * Only load overlay if container is set
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching viz types, the overlay
refreshOverlayVisibleis called before the container ref is set, causing an error because it can't determine the width. I added a check before showing the overlay, and now it works correctly: