Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show overlay if container is set #4601

Merged
merged 2 commits into from
Mar 19, 2018

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Mar 12, 2018

When switching viz types, the overlay refreshOverlayVisible is called before the container ref is set, causing an error because it can't determine the width. I added a check before showing the overlay, and now it works correctly:

switch2

@betodealmeida
Copy link
Member Author

This is broken, the width is too big. Will fix.

@codecov-io
Copy link

codecov-io commented Mar 12, 2018

Codecov Report

Merging #4601 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4601      +/-   ##
==========================================
- Coverage   71.18%   71.17%   -0.01%     
==========================================
  Files         189      189              
  Lines       14845    14846       +1     
  Branches     1086     1087       +1     
==========================================
  Hits        10567    10567              
- Misses       4275     4276       +1     
  Partials        3        3
Impacted Files Coverage Δ
superset/assets/javascripts/chart/Chart.jsx 64.95% <0%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bc089e...25ecd09. Read the comment docs.

@betodealmeida betodealmeida changed the title Instantiate ChartContainer with width Only show overlay if container is set Mar 12, 2018
@betodealmeida betodealmeida reopened this Mar 12, 2018
@mistercrunch mistercrunch merged commit ba9379b into apache:master Mar 19, 2018
@mistercrunch mistercrunch deleted the DPTOOLS-332_time_granularity_bug branch March 19, 2018 18:23
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* Pass width in props

* Only load overlay if container is set
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Pass width in props

* Only load overlay if container is set
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants