Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill Slice naming convention... #4641

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Kill Slice naming convention... #4641

merged 1 commit into from
Mar 19, 2018

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Mar 19, 2018

Missed some references of slices using this PR as a cleanup.

@codecov-io
Copy link

Codecov Report

Merging #4641 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4641   +/-   ##
=======================================
  Coverage   71.22%   71.22%           
=======================================
  Files         190      190           
  Lines       14880    14880           
  Branches     1098     1098           
=======================================
  Hits        10598    10598           
  Misses       4279     4279           
  Partials        3        3
Impacted Files Coverage Δ
...ssets/javascripts/explore/components/SaveModal.jsx 93.75% <ø> (ø) ⬆️
...ascripts/explore/components/ExploreChartHeader.jsx 71.42% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97afcd5...5761fd7. Read the comment docs.

@mistercrunch mistercrunch merged commit e9b5b1a into apache:master Mar 19, 2018
@vylc
Copy link

vylc commented Apr 26, 2018

Found a few more--new issue or add on here?
(1) Copy Dashboard - go to any dashboard, under Actions, choose Save, dialog box asks to copy slices
(2) Edit table - Details/Summary tab, Associated charts section instructions has slice references everywhere
(3) Edit chart - In the Details/Summary tab, cache timeout references slice

michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants