Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add yarn lock info to contributing.md #4679

Merged
merged 1 commit into from
Mar 23, 2018
Merged

add yarn lock info to contributing.md #4679

merged 1 commit into from
Mar 23, 2018

Conversation

timifasubaa
Copy link
Contributor

@timifasubaa timifasubaa commented Mar 23, 2018 •
edited
Loading

This adds more info about updating the yarn lock as added in (#4674)

Issue (#4274)

@graceguo-supercat @mistercrunch

@timifasubaa timifasubaa mentioned this pull request Mar 23, 2018
Closed
graceguo-supercat
graceguo-supercat approved these changes Mar 23, 2018
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #4679 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4679   +/-   ##
======================================
  Coverage    71.4%   71.4%           
======================================
  Files         190     190           
  Lines       14934   14934           
  Branches     1102    1102           
======================================
  Hits        10663   10663           
  Misses       4268    4268           
  Partials        3       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76394d3...f90f341. Read the comment docs.

@john-bodley john-bodley merged commit 00cab7e into apache:master Mar 23, 2018
john-bodley pushed a commit to john-bodley/superset that referenced this pull request Apr 10, 2018
@timifasubaa
add yarn lock info to contributing.md (apache#4679)
8fe9ad9 
(cherry picked from commit 00cab7e)
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@timifasubaa @michellethomas
add yarn lock info to contributing.md (apache#4679)
8a48783
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@timifasubaa @john-bodley
add yarn lock info to contributing.md (apache#4679)
f9d758a
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timifasubaa @codecov-io @graceguo-supercat @mistercrunch @john-bodley