[druid] Excluding refreshing verbose name #4761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4761 +/- ##
=======================================
Coverage 72.39% 72.39%
=======================================
Files 205 205
Lines 15394 15394
Branches 1182 1182
=======================================
Hits 11144 11144
Misses 4247 4247
Partials 3 3
Continue to review full report at Codecov.
|
|
Good catch LGTM |
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Apr 5, 2018
(cherry picked from commit df4ff05)
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Apr 5, 2018
[druid] Excluding refreshing verbose name (apache#4761)
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verbose name is often user defined however when refreshing Druid metrics this would be overwritten. This PR removes setting of the
verbose_nameattribute for existing metrics during a refresh.Note I added a unit test for this case and decided to re-factor the various refresh metadata checks into separate tests.
to: @michellethomas @mistercrunch