db_engine_specs: use correct sqlite week time grain #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the week of year %W and not the day of week %w when using week as time grain. Reference: https://www.sqlite.org/lang_datefunc.html
Codecov Report
@@ Coverage Diff @@
## master #4831 +/- ##
=======================================
Coverage 72.36% 72.36%
=======================================
Files 208 208
Lines 15662 15662
Branches 1227 1227
=======================================
Hits 11334 11334
Misses 4325 4325
Partials 3 3
Continue to review full report at Codecov.
|
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
We want the week of year %W and not the day of week %w when using week as time grain. Reference: https://www.sqlite.org/lang_datefunc.html
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
We want the week of year %W and not the day of week %w when using week as time grain. Reference: https://www.sqlite.org/lang_datefunc.html
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
We want the week of year %W and not the day of week %w when using week as time grain. Reference: https://www.sqlite.org/lang_datefunc.html
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the week of year %W and not the day of week %w
when using week as time grain.
Reference:
https://www.sqlite.org/lang_datefunc.html