remove hard code http scheme of short url #4656

[ripoul]

remove the hard code http. get the scheme of the request and use it to create the new url

[xrmx]

Wondering if we can use flask's url_for instead of building the url manually

[ripoul]

something like this ? (I never use url_for)

url_for(directory,  r=obj.id)

[xrmx]

@ripoul i think it would be more complicated than that to have the full url with scheme and host. Don't mind that, we can cleanup that later.

[ripoul]

how can I make the test succeed ?

[xrmx]

@ripoul you fix what hey report:
./superset/views/core.py:754:13: E122 continuation line missing indentation or outdented

that means that you have to readd the 4 spaces indentation you removed :)

[codecov-io]

Codecov Report

Merging #4886 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4886   +/-   ##
=======================================
  Coverage   76.97%   76.97%           
=======================================
  Files          44       44           
  Lines        8537     8537           
=======================================
  Hits         6571     6571           
  Misses       1966     1966

Impacted Files	Coverage Δ
superset/views/core.py	74.68% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3da8c...b28090d. Read the comment docs.

[ripoul]

@xrmx done ! ty for your help ! 😃

[john-bodley]

Would you mind elaborating in the PR description as to why/when the hard coded “http” string is problematic? This would help provide reviewers with additional context.

[ripoul]

for your first question : it's a probleme when your server accept only https request. In this case we would like to respond with the same scheme than the request to be sure the server can handle it.