[migrations] Fix time grain SQLA #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5135 +/- ##
=======================================
Coverage 77.48% 77.48%
=======================================
Files 44 44
Lines 8737 8737
=======================================
Hits 6770 6770
Misses 1967 1967Continue to review full report at Codecov.
|
john-bodley
force-pushed
the
john-bodley-time-granularity-time-column-migration
branch
from
5b26d81
to
c8eddda
Compare
|
@mistercrunch could you PTAL at this PR? We're trying to tie up a few bug fixes which are required for an upcoming deployment. |
john-bodley
deleted the
john-bodley-time-granularity-time-column-migration
branch
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
Jun 7, 2018
(cherry picked from commit 0545d11)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a migration associated with #4821 which replaces the form-data
time_grain_sqlakey with the associatedTime Columnvalue toNone. Previously without the change the cache key was misaligned between a slice within a dashboard vs. within explorer view.to: @betodealmeida @GabeLoins @michellethomas @mistercrunch