Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue with table viz for table with no metrics #5205

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Fixing issue with table viz for table with no metrics #5205

merged 1 commit into from
Jun 15, 2018

Conversation

michellethomas
Copy link
Contributor

Fixes an issue with a table viz with no metrics. Metrics can be null.

@graceguo-supercat @john-bodley @timifasubaa

@codecov-io
Copy link

Codecov Report

Merging #5205 into master will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5205      +/-   ##
==========================================
+ Coverage   63.39%   63.45%   +0.06%     
==========================================
  Files         261      261              
  Lines       19838    19838              
  Branches     1995     1995              
==========================================
+ Hits        12577    12589      +12     
+ Misses       7252     7240      -12     
  Partials        9        9
Impacted Files Coverage Δ
superset/assets/src/visualizations/table.js 9.73% <0%> (ø) ⬆️
superset/models/core.py 86.54% <0%> (+0.18%) ⬆️
superset/views/core.py 74.66% <0%> (+0.22%) ⬆️
superset/db_engine_specs.py 53.71% <0%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b7a14d...56b3f64. Read the comment docs.

graceguo-supercat
graceguo-supercat approved these changes Jun 15, 2018
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat graceguo-supercat merged commit b60ac5f into apache:master Jun 15, 2018
@michellethomas michellethomas deleted the fix_table_viz_no_metrics branch June 15, 2018 00:29
michellethomas added a commit to michellethomas/panoramix that referenced this pull request Jun 15, 2018
@michellethomas
Fixing issue with table viz for table with no metrics (apache#5205)
f57530c 
(cherry picked from commit b60ac5f)
michellethomas added a commit to airbnb/superset-fork that referenced this pull request Jun 15, 2018
@michellethomas
Merge pull request #53 from michellethomas/cherry_pick_table_no_metri…
174ce1a 
…c_fix

Fixing issue with table viz for table with no metrics (apache#5205)
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
@michellethomas @timifasubaa
Fixing issue with table viz for table with no metrics (apache#5205)
d209534
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@michellethomas
Fixing issue with table viz for table with no metrics (apache#5205)
a2ef7e9
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michellethomas @codecov-io @graceguo-supercat @mistercrunch