Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cache] Adding description for a zero cache timeout #5354

Conversation

john-bodley
Copy link
Member

This PR explicitly calls out in the forms that a timeout of 0 indicates that the cache never expires.

to: @mistercrunch

@codecov-io
Copy link

Codecov Report

Merging #5354 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5354   +/-   ##
=======================================
  Coverage   61.33%   61.33%           
=======================================
  Files         369      369           
  Lines       23488    23488           
  Branches     2713     2713           
=======================================
  Hits        14407    14407           
  Misses       9069     9069           
  Partials       12       12
Impacted Files Coverage Δ
superset/views/core.py 72.96% <ø> (ø) ⬆️
superset/connectors/druid/views.py 68.24% <ø> (ø) ⬆️
superset/connectors/sqla/views.py 70.47% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 252cba2...30d4852. Read the comment docs.

@mistercrunch
Copy link
Member

LGTM - (optional) could be good to refactor the common text into a single place

@john-bodley john-bodley merged commit c1187e0 into apache:master Jul 6, 2018
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants