Annotation Styles for Time Series Annotations #5437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5437 +/- ##
==========================================
- Coverage 59.1% 59.08% -0.02%
==========================================
Files 372 372
Lines 23742 23750 +8
Branches 2758 2762 +4
==========================================
Hits 14033 14033
- Misses 9694 9702 +8
Partials 15 15
Continue to review full report at Codecov.
|
|
@mistercrunch can we please get this merged since Fabian's approved? Thanks in advance. |
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds styling functionality to time series annotations. The 2 styles added here are "Show Markers" and "Hide Lines". Specifically this has been shown to be useful when overlaying an annotation layer that is filtered by some condition (e.g. above Upper Threshold / below Lower Threshold). This presents a view where data points that are exceeding normal values show up as Red Dots and can be identified as anomalies / outliers.