[ad-hoc filters] Fixing issue with legacy filters #5525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
approved these changes
Jul 31, 2018
john-bodley
force-pushed
the
john-bodley-fix-legacy-extra-filters
branch
from
2b4534e
to
bccc696
Compare
Codecov Report
@@ Coverage Diff @@
## master #5525 +/- ##
==========================================
+ Coverage 63.29% 63.32% +0.03%
==========================================
Files 349 349
Lines 22151 22175 +24
Branches 2459 2459
==========================================
+ Hits 14020 14042 +22
- Misses 8117 8119 +2
Partials 14 14
Continue to review full report at Codecov.
|
john-bodley
force-pushed
the
john-bodley-fix-legacy-extra-filters
branch
from
bccc696
to
3df59ff
Compare
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Jul 31, 2018
(cherry picked from commit 47e3c41)
3 tasks
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with #5206. Previously dashboard filters (
extra_filtersin the form-data defined via the legacy definition) and saved URLs with legacy filter definitions wouldn't be correctly handled in the explorer UI as they weren't included in as part of the ad-hoc filters.The solution is to convert these filters to ad-hoc filters (be it by transform legacy filters or merging the extra filters) to ensure they're correctly handled in the UI. These filters are then split into the base filters (like previously) to ensure correct handling by the various engines. Note in the future we should migrate away from having legacy filters defined anywhere.
to: @GabeLoins @graceguo-supercat @michellethomas @mistercrunch @timifasubaa